Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CafeRegisterRequest에서의 id 필드명 변경 #139

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

Ji-soo708
Copy link
Member

개요

  • 프론트의 요청으로 카페 등록 시, 사용하는 RequestBody의 id 필드를 mapId로 필드명을 변경했습니다.

작업사항

  • CafeRegisterRequest에서의 id 필드명을 mapId로 변경

주의사항

  • 추가적으로 변경되어야 할 부분이 있는지 확인해주세요.

@Ji-soo708 Ji-soo708 added the api 변경 api 스펙이 변경됐거나 기능이 변경된 작업 label Dec 6, 2023
@Ji-soo708 Ji-soo708 self-assigned this Dec 6, 2023
@Ji-soo708 Ji-soo708 changed the title style: CafeRegisterRequest에서의 id 필드명 변경 fix: CafeRegisterRequest에서의 id 필드명 변경 Dec 6, 2023
Copy link
Member

@kth990303 kth990303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

미사용 변수 제거하면 좋을듯 해요!
크게 중요한건 아니라서 approve 했습니다



Optional<Cafe> cafeOptional = cafeRepository.findByMapId(request.getId());
Optional<Cafe> cafeOptional = cafeRepository.findByMapId(request.getMapId());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금 PR 영향은 아닌 것 같긴 하지만, 이 라인 지워도 되지 않을까요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오잉 저 코드 안쓰이고 있네요 ㅋㅋㅋㅋ 지우겠습니다~

@Ji-soo708 Ji-soo708 merged commit d2216f2 into develop Dec 7, 2023
2 checks passed
@Ji-soo708 Ji-soo708 deleted the MOCACONG-464-Cafe-change-field-mapId branch December 7, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api 변경 api 스펙이 변경됐거나 기능이 변경된 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants